avoid using transactions on OSS Redis #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DvirDukhan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
+ Coverage 86.01% 86.06% +0.05%
==========================================
Files 116 116
Lines 9820 9820
==========================================
+ Hits 8447 8452 +5
+ Misses 1373 1368 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, DvirDukhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adchia
pushed a commit
that referenced
this pull request
Feb 15, 2022
Signed-off-by: DvirDukhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: DvirDukhan [email protected]
What this PR does / why we need it:
This PR avoids using Transactions in redis-py pipelines when on a single instance mode.
redis-py pipelines are created by default as transactions https://github.com/redis/redis-py/blob/24cdd70761c7c275d5010f628f83d919bf35fc90/redis/client.py#L1020
However, on cluster mode, redis-py pipeline is built with
transaction=Nonehttps://github.com/redis/redis-py/blob/045d5ed15305ccc44a0330e6f65f669998815598/redis/cluster.py#L698from https://redis.io/topics/transactions :
This could change can help increasing throughput when accessing a single Redis instance with multiple Feast clients.
Does this PR introduce a user-facing change?:
CC @chayim